Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add style prop to Bullet component #2008

Merged

Conversation

aharwood9
Copy link
Contributor

🎯 Goal

Style was never added to Bullet so was always using the default defaultMarkdownStyles. This closes #2007

🛠 Implementation details

  • Pass the correct markdown style to the Bullet component
  • Updated Bullet and ListRow to use the main style object as that already has all the defaultMarkdownStyles and then allows for full customisation.

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

  • Open the Sample App, send a message that contains an ordered or unordered list
  • See you have all the default markdown styles
  • Update the useStreamChatTheme to provide a custom colour to the list
  • See the list is now updated with the custom colour

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@aharwood9
Copy link
Contributor Author

Happy to revert to the part that enforces that listRow and bullet always override the custom styles, but felt like this gives us the power to change these if we have a use-case 👍 i.e. change the fontWeight of an ordered list

@santhoshvai santhoshvai merged commit 59b4b64 into GetStream:develop Mar 14, 2023
@santhoshvai
Copy link
Member

Thanks for the contribution @aharwood9 🙏

@aharwood9 aharwood9 deleted the fix-bullet-and-listRow-style branch March 14, 2023 17:28
@github-actions github-actions bot mentioned this pull request Mar 16, 2023
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to style Ordered or Unordered lists in Markdown
3 participants