fix: missing userSyncStatus db table upon clean install #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanGalilea
approved these changes
Mar 10, 2023
| QuickSqliteClient.initializeDatabase(); | ||
| DBSyncManager.init(client as unknown as StreamChat); | ||
| } | ||
| }, [client?.user?.id]); |
There was a problem hiding this comment.
the fact that we missed enableOfflineSupport is also a red flag
|
Kudos, SonarCloud Quality Gate passed! |
santhoshvai
changed the title
6 tasks
Merged
|
🎉 This PR is included in version 5.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
While doing a clean install with offline support, or changing from enableOfflineSupport={false} to true on the sample with no previous db table. We get the following error:
This PR aims to fix the issue.
🛠 Implementation details
A race condition happens such that the userSyncStatus table is accessed before it is created. In this PR, I added a state to wait till DB is initialized.
🎨 UI Changes
NA
🧪 Testing
☑️ Checklist
developbranch