Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misplaced date header, header/footer component in messageList on android 33 #1977

Merged
merged 7 commits into from
Feb 15, 2023
Merged

fix: misplaced date header, header/footer component in messageList on android 33 #1977

merged 7 commits into from
Feb 15, 2023

Conversation

santhoshvai
Copy link
Member

@santhoshvai santhoshvai commented Feb 15, 2023 •
edited
Loading

🎯 Goal

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@1987cr
Copy link

1987cr commented Feb 15, 2023

Just commented about this here #1968 some minutes ago, posting issue here to give visibility to the other things that are also breaking.

@santhoshvai
Copy link
Member Author

thanks @1987cr , the workaround caused some annoying UI bugs 😢

@santhoshvai santhoshvai changed the title fix: misplaced date header in android 33 fix: misplaced date header, header/footer component in messageList on android 33 Feb 15, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

51.6% 51.6% Coverage
0.0% 0.0% Duplication

@santhoshvai santhoshvai merged commit e0386be into develop Feb 15, 2023
@santhoshvai santhoshvai deleted the fix-android-33-date branch February 15, 2023 16:32
@github-actions github-actions bot mentioned this pull request Feb 15, 2023
Merged
santhoshvai added a commit that referenced this pull request Feb 17, 2023
@santhoshvai
fix: misplaced date header, header/footer component in messageList on…
17908b1 
… android 33 (#1977) (#1978)

* fix: android 33 showed date separator at the bottom instead of at the top

* chore: update sample apps to rn 0.70.7

* chore: update podfile lock

* chore: update lock files

* fix: message list header and footer were broken on android 33

* chore: update snapshots
@github-actions github-actions bot mentioned this pull request Mar 16, 2023
Merged
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] Inverted empty state for message list
3 participants
@santhoshvai @1987cr @stream-ci-bot