Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different Attachment Types within one Message cause invalid rendering (Compose UI) #5222

Open
jnischler opened this issue Mar 28, 2024 · 4 comments
Labels

Comments

@jnischler
Copy link

Describe the bug
Having multible different attachments within one message are displayed invalid.
The first matched attachment factory needs to render all attachments also not matched attachments.

SDK version

  • 6.2.3

To Reproduce
Steps to reproduce the behavior:

  1. Register at least 2 different attachmentFactories
  2. add 2 different attachments to your message
  3. post the message
  4. See error

Expected behavior
Only matched attachments should be rendered by the corresponding attachment factory.

Regards
Julian

@jnischler jnischler added the bug Something isn't working label Mar 28, 2024
@jnischler
Copy link
Author

At this position you are only checking for the first possible handler so if there is a file in the attachments the file handler will kick in but the media handler cant handle.
This should be changed to a per attachment basis oder you need to group the attachments by type this would make the most sense here.

@jnischler
Copy link
Author

bump

@jnischler
Copy link
Author

any news on this ?
this should be fixed!

@kanat
Copy link
Collaborator

kanat commented Aug 29, 2024

Hi @jnischler,

Thank you very much for bringing this to our attention and for the detailed explanation.
It seems that this might be more in line with a feature request rather than an issue.

We appreciate your valuable input and are always keen to improve the product based on user feedback.

@kanat kanat added feature request compose Jetpack Compose and removed bug Something isn't working labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants