Publish DKAN on Drupal.org

[acouch]

We can't publish DKAN on Drupal.org because some of the libraries are not GPL2 compatible. See: https://www.drupal.org/packaging-whitelist . This issue can track that:

Library	version	OK on drupal.org
backbone	1.0.0	yes
bootstrap	2.3.2	yes, bootstrap > 3.2 is OK, would require upgrading bootstrap in recline
flot		yes
flotr2		yes
jquery	1.7.1	yes
json		no sure
leaflet.markercluster		yes
leaflet	0.7.3	yes
moment	2.0.0	yes
mustache	0.5.0-dev	yes
showdown		not whitelisted
slickgrid	2.0.1	yes
timeline		not whitelisted
underscore.deferred	0.4.0	yes
underscore	1.4.4	yes

[stopfstedt]

requested leaflet.markercluster to be whitelisted https://www.drupal.org/node/2367231

[stopfstedt]

requested showdown to be whitelisted https://www.drupal.org/node/2367281

[acouch]

thanks!

[stopfstedt]

@acouch you bet! will put some more whitelist requests in over the weekend as applicable.

[acouch]

fantastic

[stopfstedt]

put four more whitelist-requests in:

• Please whitelist the mustache.js library
• Please whitelist the Flotr2 library
• Please whitelist the SlickGrid library
• Please whitelist the underscore.deferred library

still todo: whitelist requests for moment and timeline.

[kreynen]

I reviewed the whitelist requests this morning. Unfortunately Flotr2 and showdown have issues and cannot be whitelisted as they are now. Some of these issues could be solved if the DA starts reducing the restrictions on requiring a GPL license for all code and assets and prohibiting 3rd part libraries from being committed to Drupal's git repo. It has taken years to get to the point they are reviewing a charter for a licensing working group (https://groups.drupal.org/node/445098). Once that is approved, the group will actually have the authority to start making small changes like allowing "GPL friendly" licenses like SIL OFL for fonts and Create Commons for content as well as allowing 3rd party code that can't be used without modification (in this case, removing Apache2 libraries). This group will not have the authority to allow distributions the option of distributing Drupal core w/ a GPLv3 (thus allowing them to include Apache2 code). Currently it is perfectly legal to do that on GitHub, but not Drupal.org. That change will require approval from Dries himself, but we need to both track the distributions using alternatives to maintain a distribution as well as show that those maintainers are interested in using Drupal.org.

Adding the reasons why you want to use Drupal.org to package your distribution to https://www.drupal.org/node/1449452 will only help move that forward.

[stopfstedt]

@kreynen thanks for the feedback!

[acouch]

Just tried to publish. Here are the errors:

Starting Drupal.org contrib makefile validation, please wait [ok]
The top-level attribute '# RECLINE [error]
libraries' is not allowed.
The top-level attribute '# LODASH [error]
libraries' is not allowed.
The top-level attribute '# BACKBONE [error]
libraries' is not allowed.
The top-level attribute '# CSV BACKEND [error]
libraries' is not allowed.
The top-level attribute '# SLICKGRID [error]
libraries' is not allowed.
The top-level attribute '# MUSTACHE [error]
libraries' is not allowed.
The top-level attribute '# MOMENT [error]
libraries' is not allowed.
The top-level attribute '# LEAFLET [error]
libraries' is not allowed.
The top-level attribute '# FLOT [error]
libraries' is not allowed.
The top-level attribute '# FLITBIT [error]
libraries' is not allowed.
The top-level attribute '# DEEPLINK [error]
libraries' is not allowed.
The top-level attribute '# MARKER CLUSTER [error]
libraries' is not allowed.
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project
'leaflet_draw_widget'.
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'leaflet_draw_widget' is
invalid (https://github.com/NuCivic/leaflet_draw_widget.git).
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'recline' is invalid
(https://github.com/NuCivic/recline.git).
The project download-level attribute 'version' on project 'entity' is [error]
not allowed.
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project 'entity_rdf'.
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'field_group_table' is invalid
(https://github.com/nuams/field_group_table.git).
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project 'gravatar'.
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project
'link_iframe_formatter'.
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project 'multistep'.
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project 'og_extras'.
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'open_data_schema_map' is
invalid (https://github.com/NuCivic/open_data_schema_map.git).
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'open_data_schema_map_dkan' is
invalid (https://github.com/NuCivic/open_data_schema_map_dkan.git).
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project 'ref_field'.
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'feeds_flatstore_processor' is
invalid (https://github.com/NuCivic/feeds_flatstore_processor.git).
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'dkan_dataset' is invalid
(https://github.com/NuCivic/dkan_dataset.git).
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'dkan_datastore' is invalid
(https://github.com/NuCivic/dkan_datastore.git).
The patch 'patches/panopoly_widgets_overrides.patch' is not hosted on [error]
drupal.org
The project download-level attribute 'version' on project 'bootstrap' [error]
is not allowed.
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project 'bootstrap'.
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'nuboot' is invalid
(https://github.com/NuCivic/nuboot.git).
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'nuboot_radix' is invalid
(https://github.com/NuCivic/nuboot_radix.git).
The library 'leaflet_draw' cannot be downloaded from [error]
https://github.com/Leaflet/Leaflet.draw.git, the URL must be in the
whitelist available at https://www.drupal.org/packaging-whitelist.
The library 'leaflet_core' cannot be downloaded from [error]
https://github.com/Leaflet/Leaflet.git, the URL must be in the
whitelist available at https://www.drupal.org/packaging-whitelist.
The library 'recline' cannot be downloaded from [error]
https://github.com/NuCivic/recline.js.git, the URL must be in the
whitelist available at https://www.drupal.org/packaging-whitelist.
The library 'lodash' cannot be downloaded from [error]
https://github.com/lodash/lodash.git, the URL must be in the
whitelist available at https://www.drupal.org/packaging-whitelist.
The library 'csv' cannot be downloaded from [error]
https://github.com/okfn/csv.js.git, the URL must be in the whitelist
available at https://www.drupal.org/packaging-whitelist.
The library 'leaflet' cannot be downloaded from [error]
https://github.com/Leaflet/Leaflet.git, the URL must be in the
whitelist available at https://www.drupal.org/packaging-whitelist.
The library 'deep_diff' cannot be downloaded from [error]
https://github.com/flitbit/diff.git, the URL must be in the whitelist
available at https://www.drupal.org/packaging-whitelist.
The library 'recline_deeplink' cannot be downloaded from [error]
https://github.com/NuCivic/recline-deeplink.git, the URL must be in
the whitelist available at
https://www.drupal.org/packaging-whitelist.
The library 'slugify' cannot be downloaded from [error]
https://github.com/pmcelhaney/jQuery-Slugify-Plugin.git, the URL must
be in the whitelist available at
https://www.drupal.org/packaging-whitelist.
The library 'excanvas' cannot be downloaded from [error]
https://explorercanvas.googlecode.com/files/excanvas_r3.zip, the URL
must be in the whitelist available at
https://www.drupal.org/packaging-whitelist.
The library 'font_awesome' cannot be downloaded from [error]
https://github.com/FortAwesome/Font-Awesome.git, the URL must be in
the whitelist available at
https://www.drupal.org/packaging-whitelist.
The Drupal.org validation check failed -- see [error]
https://www.drupal.org/node/1432190 for more information.
Once these errors are fixed, commit the changes to your drupal-org.make, move the release tag for your project (check the Git manual to learn how to move tags if necessary), and submit the release node again.

[kreynen]

Following the logic here, these errors aren't from the distribution .make, but the recline .make in dkan_dataset .make include at https://github.com/NuCivic/dkan/blob/7.x-1.x/drupal-org.make#L12. Looking at
https://github.com/NuCivic/recline/blob/7.x-1.x/recline.make, I'm not seeing anything obvious.

I think the "The top-level attribute '#..." error message itself might be caused by "The URL for project 'recline' is invalid
(https://github.com/NuCivic/recline.git)." That part is easy, since https://www.drupal.org/packaging-whitelist?title=recline. I haven't checked all of these, but the ones I have are not whitelisted at all or not from the repo URL you are trying to use.

ALL URLs included in any .make have to be whitelisted or the Drupal validation will fail. It is going to take awhile to get the all of these projects whitelisted, but I can save you some time on a few...

FontAwesome - SIL OFL is not strictly GPL compatible. It is now labelled as GPL friendly and can not be whitelisted until the revisions to the Drupal.org git and licensing policies the LWG proposed are approved. As soon as that happens, FontAwesome will be whitelisted. If you absolutely need FontAwesome to be included on install, take a look at https://www.drupal.org/node/2427075. A number of other distributions are using FontAwesome via a CDN while we've been waiting for the changes to Drupal.org.
Excanvas - Update to the GitHub repo. Google is shutting googlecode.com down. We are no longer whitelisting code on googlecode.com.
Leaflet - several whitelist entries, but none include that repo. Not sure if we need to update or add another entry.

Some of the libraries that are failing validation may just need updates made to the regex, but several need to be reviewed before they can be whitelisted. If you add those requests to https://www.drupal.org/project/issues/drupalorg_whitelist, I'll do what I can to get those published this week.

[acouch]

Some of the libraries that are failing validation may just need updates made to the regex

Yes, backbone is whitelisted https://www.drupal.org/packaging-whitelist?title=backbone but the regex isn't picking it up correctly.

Looks like someone will need to work through those.

but several need to be reviewed before they can be whitelisted. If you add those requests to

Also true.

I'll do what I can to get those published this week.

FANTASTIC!

[acouch]

This is the most recent report when trying to create a release on drupal.org:

The top-level attribute '# RECLINE [error]
libraries' is not allowed.
The top-level attribute '# LODASH [error]
libraries' is not allowed.
The top-level attribute '# BACKBONE [error]
libraries' is not allowed.
The top-level attribute '# CSV BACKEND [error]
libraries' is not allowed.
The top-level attribute '# SLICKGRID [error]
libraries' is not allowed.
The top-level attribute '# MUSTACHE [error]
libraries' is not allowed.
The top-level attribute '# MOMENT [error]
libraries' is not allowed.
The top-level attribute '# LEAFLET [error]
libraries' is not allowed.
The top-level attribute '# FLOT [error]
libraries' is not allowed.
The top-level attribute '# FLITBIT [error]
libraries' is not allowed.
The top-level attribute '# DEEPLINK [error]
libraries' is not allowed.
The top-level attribute '# MARKER CLUSTER [error]
libraries' is not allowed.
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project
'leaflet_draw_widget'.
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'leaflet_draw_widget' is
invalid (https://github.com/NuCivic/leaflet_draw_widget.git).
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'recline' is invalid
(https://github.com/NuCivic/recline.git).
The project download-level attribute 'full_version' on project [error]
'entity' is not allowed.
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project 'entity_rdf'.
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'field_group_table' is invalid
(https://github.com/nuams/field_group_table.git).
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project 'gravatar'.
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project
'link_iframe_formatter'.
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project 'multistep'.
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project 'og_extras'.
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'open_data_schema_map' is
invalid (https://github.com/NuCivic/open_data_schema_map.git).
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'open_data_schema_map_dkan' is
invalid (https://github.com/NuCivic/open_data_schema_map_dkan.git).
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project 'ref_field'.
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'feeds_flatstore_processor' is
invalid (https://github.com/NuCivic/feeds_flatstore_processor.git).
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'dkan_dataset' is invalid
(https://github.com/NuCivic/dkan_dataset.git).
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'dkan_datastore' is invalid
(https://github.com/NuCivic/dkan_datastore.git).
The patch 'patches/panopoly_widgets_overrides.patch' is not hosted on [error]
drupal.org
The project download-level attribute 'version' on project 'bootstrap' [error]
is not allowed.
The project download-level attribute 'branch' must be defined when [error]
the 'revision' attribute is specified on project 'bootstrap'.
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'nuboot' is invalid
(https://github.com/NuCivic/nuboot.git).
The download-level attribute 'url' can only be used if it is pointing [error]
to git.drupal.org. The URL for project 'nuboot_radix' is invalid
(https://github.com/NuCivic/nuboot_radix.git).
The library 'leaflet_draw' cannot be downloaded from [error]
https://github.com/Leaflet/Leaflet.draw.git, the URL must be in the
whitelist available at https://www.drupal.org/packaging-whitelist.
The library 'leaflet_core' cannot be downloaded from [error]
https://github.com/Leaflet/Leaflet.git, the URL must be in the
whitelist available at https://www.drupal.org/packaging-whitelist.
The library 'recline' cannot be downloaded from [error]
https://github.com/NuCivic/recline.js.git, the URL must be in the
whitelist available at https://www.drupal.org/packaging-whitelist.
The library 'lodash' cannot be downloaded from [error]
https://github.com/lodash/lodash.git, the URL must be in the
whitelist available at https://www.drupal.org/packaging-whitelist.
The library 'csv' cannot be downloaded from [error]
https://github.com/okfn/csv.js.git, the URL must be in the whitelist
available at https://www.drupal.org/packaging-whitelist.
The library 'leaflet' cannot be downloaded from [error]
https://github.com/Leaflet/Leaflet.git, the URL must be in the
whitelist available at https://www.drupal.org/packaging-whitelist.
The library 'deep_diff' cannot be downloaded from [error]
https://github.com/flitbit/diff.git, the URL must be in the whitelist
available at https://www.drupal.org/packaging-whitelist.
The library 'recline_deeplink' cannot be downloaded from [error]
https://github.com/NuCivic/recline-deeplink.git, the URL must be in
the whitelist available at
https://www.drupal.org/packaging-whitelist.
The library 'slugify' cannot be downloaded from [error]
https://github.com/pmcelhaney/jQuery-Slugify-Plugin.git, the URL must
be in the whitelist available at
https://www.drupal.org/packaging-whitelist.
The library 'excanvas' cannot be downloaded from [error]
https://explorercanvas.googlecode.com/files/excanvas_r3.zip, the URL
must be in the whitelist available at
https://www.drupal.org/packaging-whitelist.
The library 'font_awesome' cannot be downloaded from [error]
https://github.com/FortAwesome/Font-Awesome.git, the URL must be in
the whitelist available at
https://www.drupal.org/packaging-whitelist.
The Drupal.org validation check failed -- see [error]
https://www.drupal.org/node/1432190 for more information.
Once these errors are fixed, commit the changes to your drupal-org.make, move the release tag for your project (check the Git manual to learn how to move tags if necessary), and submit the release node again.

[acouch]

Closing this ticket as it has not been updated recently and is not on our near-term roadmap. Please re-open if you would like to discuss further or are actively working on it.