Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Since I haven't updated in a while; possible rewrite? [PUT ON HOLD] #36

Open
Gerschel opened this issue Mar 28, 2023 · 9 comments
Open

Comments

@Gerschel
Copy link
Owner

Gerschel commented Mar 28, 2023

@Nacurutu
I can't promise to devote time to it yet, I might have a couple of days between April 25th and May 1st, to attempt a parital rewrite.
In the meantime, I might be able to squeeze in a few fixes. What seem to be the most pressing issues that need addressed sooner?

Also. We can probably put together a checklist of things that should be in a rewrite.

@Nacurutu
Copy link
Collaborator

hi, welcome back.. no worries, your life and work first, then, the coding hobby...

I really don't know about the issues because I haven't updated the webUI, also, I'm full of work right now, didn't have the chance to check it, I was planning to install the webUI on a new folder on Sunday (a little of free time) to not mess with the one working "properly" and check for possible bugs/issues. I'm full of work and also I'm moving to a new place, this week has been a mess :p

I hope I can help on Sunday.. but honestly, I cant promise.

@Gerschel
Copy link
Owner Author

Yep. It's not like we get paid, typically we get ripped off. No worries, we'll get there at some point.

@ParityError
Copy link

Yes. wb! I looked through the latest automatic1111 webui and it looks like the most recent version of gradio it uses is eventually going to support theming. There are loads of new vars showing up in the css that don't seem to be implemented yet. The quickcss extension still works (sorta), although there are some issues now with the color pickers, and of course they had to change the id and class names of things so it's a mess.

The extension still provides maximum flexibility as far as customization is concerned; I hope we can keep it going when time permits.

@Gerschel
Copy link
Owner Author

We also have the option of custom classes through gradio now too. gradio-app/gradio#2962 (comment)

@ParityError
Copy link

I was able to get my "blueprint" .css to work properly with the latest commit of automatic1111 (since i couldn't stand the default gradio style). It took quite a bit of effort to track down all the changes in the latest gradio .css but I was able to resolve almost everything. If you want to provide it as a temporary fix for your extension let me know.

Screenshot 2023-03-30 at 12 35 22 PM

@Piscabo
Copy link

Piscabo commented Mar 31, 2023

I was able to get my "blueprint" .css to work properly with the latest commit of automatic1111 (since i couldn't stand the default gradio style). It took quite a bit of effort to track down all the changes in the latest gradio .css but I was able to resolve almost everything. If you want to provide it as a temporary fix for your extension let me know.

Screenshot 2023-03-30 at 12 35 22 PM

Where can I pull this from? PLS.

@oakif
Copy link

oakif commented Apr 5, 2023

@ParityError Hey! Also wanted to ask if you have a version of this somewhere. I just updated to the latest commit 22bcc7be in SD and it broke this extension from my previous update, which had been 3715ece0.

@Gerschel
Copy link
Owner Author

Gerschel commented May 4, 2023

This project is temporarily on hold until I get the other project working. This one would take longer to rework.

@Gerschel Gerschel pinned this issue May 4, 2023
@Gerschel Gerschel changed the title Since I haven't updated in a while; possible rewrite? Since I haven't updated in a while; possible rewrite? [PUT ON HOLD] May 4, 2023
@oakif
Copy link

oakif commented May 5, 2023

Appreciate the update! I currently have been using the below theme:

https://github.com/canisminor1990/sd-webui-kitchen-theme

Hope someone finds it useful!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants