Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FullScreen API supported by Safari 16.4 #901

Closed
dtrucs opened this issue Mar 30, 2023 · 2 comments
Closed

FullScreen API supported by Safari 16.4 #901

dtrucs opened this issue Mar 30, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@dtrucs
Copy link
Collaborator

dtrucs commented Mar 30, 2023

With the release of Safari 16.4 and the support of fullscreen API, it might be worth improving the condition here

Geotrek-rando-v3/frontend/src/components/Modal/Modal.tsx

Line 30 in 01785fa

(/^iP/.test(navigator.platform) ||

@dtrucs dtrucs added the enhancement New feature or request label Mar 30, 2023
@dtrucs dtrucs mentioned this issue Jun 17, 2024
Merged
@dtrucs
Copy link
Collaborator Author

dtrucs commented Jun 17, 2024

To avoid any confusion, fullscreen API support for IOS only works for <video> tags.
Currently, we don't use the fullscreen API for videos (only for images), so once the condition mentioned is fixed, it won't work any better.
But it's a future solution for integrating video from this ticket #375 for example.

@dtrucs
Copy link
Collaborator Author

dtrucs commented Jul 20, 2024

No more condition related to the platform since 3.21.0.

@dtrucs dtrucs closed this as completed Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dtrucs