Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to React 18.3.* and higher #1219

Closed
dtrucs opened this issue Aug 8, 2024 · 3 comments
Closed

Migration to React 18.3.* and higher #1219

dtrucs opened this issue Aug 8, 2024 · 3 comments
Assignees

Comments

@dtrucs
Copy link
Collaborator

dtrucs commented Aug 8, 2024

Currently, Geotrek-Rando applications run on React 18.2.0.

Soon, there will be a major new version of React (19) and a migration should be necessary.
In the meantime, the React team has released version 18.3.1, which is the same code as 18.2.0, but with added warnings. These warnings will become errors in the future major version.

Fortunately, in testing version 18.3.1 we don't have so many warnings.

It should be necessary to update (or change) the react-burger-menu package (not updated for 2 years) allowing to create side menus for mobile viewports.

For the moment, I can't see anything else, but I'll keep this ticket up to date.

@babastienne
Copy link
Member

Thanks @dtrucs for your ticket and for keeping this soft up to date. 🙏

@dtrucs
Copy link
Collaborator Author

dtrucs commented Aug 20, 2024

React-leaflet also appears to be incompatible with React 19. The lead developer is working on a 5.* version.
There's a lot of work to do to migrate Geotrek-Rando :

  • upgrade leaflet from 1.7.1 to 1.9.0
  • upgrade react-leaflet from 3.1.0 to the latest version
  • adapt all plugins around leaflet (geolocation, cluster, elevation profile, etc)

@dtrucs
Copy link
Collaborator Author

dtrucs commented Oct 8, 2024

Fixed since 3.23.0

@dtrucs dtrucs closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants