Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix signage attachment access if published #3118

Merged
merged 2 commits into from
May 25, 2022

Conversation

submarcos
Copy link
Member

No description provided.

@cypress
Copy link

cypress bot commented May 25, 2022



Test summary

22 0 0 0


Run details

Project Geotrek-admin
Status Passed
Commit 015e649
Started May 25, 2022 9:51 AM
Ended May 25, 2022 9:54 AM
Duration 03:06 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #3118 (015e649) into master (5369642) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3118   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files         272      272           
  Lines       18784    18784           
=======================================
  Hits        18334    18334           
  Misses        450      450           
Impacted Files Coverage Δ
geotrek/common/mixins/models.py 97.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5369642...015e649. Read the comment docs.

@submarcos submarcos marked this pull request as ready for review May 25, 2022 10:14
@submarcos submarcos requested a review from a team May 25, 2022 10:14
@submarcos submarcos merged commit 5919868 into master May 25, 2022
@LePetitTim LePetitTim deleted the fix_signage_attachment_access branch May 25, 2022 12:41
@camillemonchicourt
Copy link
Member

Hello, j'ai mis à jour mon Geotrek-admin en version 2.83.0 qui inclut cette correction.
Mais je n'ai toujours pas accès aux images des signalétiques publiées.
Exemple sur https://gtr3demo.ecrins-parcnational.fr/trek/2-Col-de-Font-Froide
L'image n'est pas accessible sans autorisation : https://geotrekdemo.ecrins-parcnational.fr/media/paperclip/signage_signage/76/capture-decran-de-2021-10-13-22-07-10.png.400x0_q85.jpg

Ou alors ça peut être une histoire de cache ?

@GeotrekCE GeotrekCE deleted a comment from thomasmagninfeysot Jun 2, 2022
@camillemonchicourt
Copy link
Member

Bon j'ai testé sur mon serveur de production et je n'ai pas le soucis, donc il est possible que cela soit la conf NGINX de mon serveur DEMO qui ai un soucis. Même si je vois pas pourquoi j'ai le soucis sur les signalétiques et pas les randos, POI, etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants