Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu remains visible until a row is selected if visible when off() is called #50

Open
jburn7 opened this issue May 17, 2023 · 1 comment

Comments

@jburn7
Copy link

jburn7 commented May 17, 2023

  1. attach menu to DOM via const menu = new VanillaContextMenu() and store reference
  2. right click to make context menu visible
  3. call menu.off() while menu still visible

Now there is no way to make the menu disappear by clicking outside of it since its click handler was removed

Possible remediation:

  off(): void {
    this.#removeExistingContextMenu();
    ...
  }
@GeorgianStan
Copy link
Owner

Hi @jburn7! Thank you for bringing this up. I have started to work on a new major version were I'll try to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants