report on poorly configured proxy communications

[jessereynolds]

At a customer site we ran into the following problem:

• /etc/profile.d/proxy.sh was setting http_proxy, HTTP_PROXY, https_proxy, HTTPS_PROXY to be the company's outbound proxy server. This is required for internet access, including during installation of puppet enterprise
• however the local IP that puppet services should listen on was not present in the no_proxy, NO_PROXY environment variables, so later on we get an error about classification not being able to be set, presumably because local http/https communications were being routed via the company's proxy servers

The workaround during installation was to add the local IP for the puppet master fqdn to the no_proxy and NO_PROXY environment variables

Perhaps the preflight could look for the presence of any http(s)_proxy environment variables, and if they are present, check that there is also an exclusion in no_proxy corresponding to the master's ip.

[GeoffWilliams]

not a bad idea :) I haven't maintained this script for a while - if I revisit it this is certainly something to look at