Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0 #746

Closed
18 tasks done
MFraters opened this issue Aug 19, 2024 · 3 comments
Closed
18 tasks done

Release v1.0 #746

MFraters opened this issue Aug 19, 2024 · 3 comments

Comments

@MFraters
Copy link
Member

MFraters commented Aug 19, 2024

The JOSS paper is now in the post-review steps! See openjournals/joss-reviews#6671 for more info.

This means that a new release is needed.

Here is the todo list:

Here is the todo list:

Please let me know if there are any other items which should be checked before the release, or which may delay it.

@tjhei
Copy link
Contributor

tjhei commented Aug 20, 2024

  • --> Note: Benchmarks won't work until this pull request is merged.

I would expect that you can bump GWB version and the expected version and the .json files in the same commit, no?

@MFraters
Copy link
Member Author

If I remember correctly, the problem is that the benchmarks test the main version of the world builder, against the pull request version of the world builder, with the pull request version input files (you want to use the same input files for both). So the pull request which bumps the version, the benchmarks won't work.

@MFraters
Copy link
Member Author

Release fully done! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants