From ef896255bfe9d2b2a2d199e3366c32d038e6d546 Mon Sep 17 00:00:00 2001 From: Lorraine Hwang Date: Fri, 16 Feb 2024 09:18:25 -0800 Subject: [PATCH 1/2] Update constant_angle_in_spherical_domain_issue.md Edits for clarity. Please feel free to edit. --- .../concepts/constant_angle_in_spherical_domain_issue.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/sphinx/user_manual/concepts/constant_angle_in_spherical_domain_issue.md b/doc/sphinx/user_manual/concepts/constant_angle_in_spherical_domain_issue.md index ce4399266..546fb4c28 100644 --- a/doc/sphinx/user_manual/concepts/constant_angle_in_spherical_domain_issue.md +++ b/doc/sphinx/user_manual/concepts/constant_angle_in_spherical_domain_issue.md @@ -2,9 +2,9 @@ Constant angle in spherical domain issue ======================================== -There is one last concept we need to discuss before we can move on to the {ref}`part:user_manual:chap:basic_starter_tutorial:sec:index`, which is the problem of defining what a constant angle in a sphere is. This does not matter for Cartesian models, but is important fore line features in spherical models. +There is one last concept we need to discuss before we can move on to {ref}`part:user_manual:chap:basic_starter_tutorial:sec:index`, this is the problem of defining a constant angle in a sphere. This does not matter for Cartesian models but is important for line features in spherical models. -The issue arises when you want to define a line with a certain angle to the surface in a sphere. The problem here is that there are two ways of looking at this. The first way is to see a constant angle with the point it starts at. This works fine, except that for large distances it will burst through the surface of the planet out into space. This can be see in the left figure below. The other option is to look at a constant angle as an angle which remains constant with the surface above. This results in a logarithmic spiral as seen in the right figure below. +When defining a line with a certain angle to the surface in a sphere, you can look at this in one of two ways. The first option is to define a constant angle at its starting point. This works mostly fine except for large distances where it will burst through the surface of the planet out into space. This can be see in the left figure below. The other option is to define a constatnt angle with respect to the surface above. This results in a logarithmic spiral as seen in the right figure below. ::::{grid} 2 @@ -22,6 +22,6 @@ The issue arises when you want to define a line with a certain angle to the surf ::: :::: -Currently only the left figure, and something in between the left and right figure has been implemented in the GWB. The in between option is that for each line segment it can adjust the angle to be the correct angle with respect to the surface. Implementing the way it is done in the right figure, is possible if there is enough interest. +Currently only the first option (left figure), and something in between the first and second option (right figure) has been implemented in the GWB. For this in between option, the angle of each line segment can be adjusted to the correct angle with respect to the surface. Implementing this fully (right figure) is possible if there is enough interest. -In the GWB this is defined in the spherical coordinate system through something called a `depth method`. The left figure method is called `starting point`, because the angle is set and kept relative to the starting point. The in between option is called `begin segment`, because the angle is relative to the beginning of each segment. The right figure method is called `contiuous`, and is not implemented. +In the GWB this concept is defined in the spherical coordinate system through something called a `depth method`. The left figure method is called `starting point` because the angle is set and kept relative to the starting point. The in between option is called `begin segment` because the angle is relative to the beginning of each segment. The right figure method is called `contiuous` and is not implemented. From 2dfcc38f262fdb7d4980b5eb9bf52b6188e10092 Mon Sep 17 00:00:00 2001 From: Rene Gassmoeller Date: Fri, 16 Feb 2024 13:48:47 -0600 Subject: [PATCH 2/2] Fix typos --- .../concepts/constant_angle_in_spherical_domain_issue.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/sphinx/user_manual/concepts/constant_angle_in_spherical_domain_issue.md b/doc/sphinx/user_manual/concepts/constant_angle_in_spherical_domain_issue.md index 546fb4c28..fd60d58a8 100644 --- a/doc/sphinx/user_manual/concepts/constant_angle_in_spherical_domain_issue.md +++ b/doc/sphinx/user_manual/concepts/constant_angle_in_spherical_domain_issue.md @@ -4,7 +4,7 @@ Constant angle in spherical domain issue There is one last concept we need to discuss before we can move on to {ref}`part:user_manual:chap:basic_starter_tutorial:sec:index`, this is the problem of defining a constant angle in a sphere. This does not matter for Cartesian models but is important for line features in spherical models. -When defining a line with a certain angle to the surface in a sphere, you can look at this in one of two ways. The first option is to define a constant angle at its starting point. This works mostly fine except for large distances where it will burst through the surface of the planet out into space. This can be see in the left figure below. The other option is to define a constatnt angle with respect to the surface above. This results in a logarithmic spiral as seen in the right figure below. +When defining a line with a certain angle to the surface in a sphere, you can look at this in one of two ways. The first option is to define a constant angle at its starting point. This works mostly fine except for large distances where it will burst through the surface of the planet out into space. This can be seen in the left figure below. The other option is to define a constant angle with respect to the surface above. This results in a logarithmic spiral as seen in the right figure below. ::::{grid} 2