-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: drop git-cliff #16
Comments
@jrson83 I agree with your perspective. I have also been using git-cliff in a simple manner before, but I didn't realize it had so many issues. I have thought about developing my own git log generation application, and currently, it seems to be the most reasonable and efficient solution. If we develop this application, I would be delighted to work on it with you because I have a strong interest in git myself and am looking forward to creating a git-related application. Here are a few suggestions from my side:
Additionally, I think the proposal for removing spark.json makes sense. Let's remove it in the next version. |
@Geocld I don't know rust. But in Node.js the right approach would be to use
I recommend reading this post on A Performance Comparison of Node.js Methods for Reading Large Datasets I have found the problem what causes the multiple issues I opend. Is it possible you please give me access to the repo, to commit to the main branch? So I do not need to wait for PR merge. |
@jrson83 Good jobs! I had Invited you to this repo collaborators. |
@Geocld I checked again the issue with monorepo #13. I now understand what problem you had and that you used the current I think this is really bad, especially sparkee is build for monorepo, but git-cliff does not properly support monorepo.
Thank you!
So you mean an independent package, but sparkee can use that package internally to generate a changelog? So we could build a monorepo and create that new Can you please release a new version of sparkee, so we can test if it is working. |
@jrson83 New commits had published in v1.3.1. |
@Geocld can I restrict the package manager for sparkee repo to pnpm? EDIT: Can you please release next version 💌 |
Proposal
So at first I thought git-cliff is cool. But there are multiple reasons I would prefer to drop git-cliff and write the changelog generator by ourselfs.
Git-cliff
Configuration files
Before using git-cliff, it was possible to configure the changelog generator using spark.json
logPresetTypes
.Now in addition to spark.conf you need another .toml configuration file.
At the moment, the spark.json is actually obsolete, since it holds only two options:
moduleManager
packages
Those options are resolved on init either using package.json or pnpm-workspace.yaml.
When keeping git-cliff it would make sense to drop spark.json and resolve the options at run time, from package.json or pnpm-workspace.yaml.
Solution
It would be great if you willing to drop git-cliff and replace it with a custom changelog generator.
I be willing to implement the changelog generator.
The text was updated successfully, but these errors were encountered: