Only support Python >= 3.5 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As the Window testing on appveyor will be replaced by TravisCI, I won't bother with the failed appveyor builds. |
MuellerSeb
reviewed
Nov 19, 2019
| shutil.rmtree(self.dir_name) | ||
|
|
||
|
|
||
| TemporaryDirectory = getattr( |
There was a problem hiding this comment.
You have to import TemporaryDirectory from tempfile now or use it by tempfile.TemporaryDirectory
LSchueler
force-pushed
the
python-version-requirements
branch
from
13b3761 to
f074473
Compare
MuellerSeb
approved these changes
Nov 20, 2019
|
The diff for |
MuellerSeb
changed the title
This was referenced Nov 20, 2019
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #40, I've now added the hard Python version requirements for the currently supported versions to the setup.py
Next commits, we can change the line to
python_requires=">=3.5.*",