Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --XXX-buffer options #5403

Closed
rom1v opened this issue Oct 25, 2024 · 0 comments
Closed

Rename --XXX-buffer options #5403

rom1v opened this issue Oct 25, 2024 · 0 comments

Comments

@rom1v
Copy link
Collaborator

rom1v commented Oct 25, 2024

There are 3 options to add delay/buffering:

(and there is also a separate option --audio-output-buffer=, which is a workaround for some systems)

The naming is inconsistent: why --audio-buffer and not --video-buffer?

It's for historical reasons (there was only --display-buffer initially).

And there are 2 options related to video buffering (one for display, one for v4l2) and only one for audio. But this is "accidental", if we add the equivalent of v4l2 (pipewire) for audio, there would be another audio buffering option.

For consistency, I would like to rename --display-buffer= and audio-buffer= , either to:

  • --video-playback-buffer=
  • --audio-playback-buffer=
    or
  • --video-buffer=
  • --audio-buffer= (unchanged)

(--v4l2-buffer would be kept as is)

I like "video playback buffer" and "audio playback buffer" because it precisely describes what it refers to, but the options names are long.

I like "video buffer" and "audio buffer" because they are short, but --video-buffer= may suggest that it also applies to v4l2 (or even other use cases like recording).

(I think I prefer --video-buffer and --audio-buffer for now.)

What do you think?

rom1v added a commit that referenced this issue Oct 29, 2024
For consistency with --audio-buffer, rename --display-buffer to
--video-buffer.

Fixed #5403 <#5403>
rom1v added a commit that referenced this issue Oct 29, 2024
For consistency with --audio-buffer, rename --display-buffer to
--video-buffer.

Fixed #5403 <#5403>
@rom1v rom1v closed this as completed in c29ecd0 Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant