Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop-file-validate fails on provided .desktop files #3633

Closed
2 tasks done
zenofile opened this issue Dec 22, 2022 · 0 comments
Closed
2 tasks done

desktop-file-validate fails on provided .desktop files #3633

zenofile opened this issue Dec 22, 2022 · 0 comments

Comments

@zenofile
Copy link

zenofile commented Dec 22, 2022

  • I have read the FAQ.

  • I have searched in existing issues.

  • scrcpy version: 1.25

During the packaging of scrcpy for Fedora COPR, I noticed both scrcpy.desktop and scrcpy-console.desktop do not pass the desktop-file-validate validation process:

scrcpy.desktop

$ desktop-file-validate scrcpy.desktop
scrcpy.desktop: error: value "/bin/sh -c '"$SHELL" -i -c scrcpy'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
scrcpy.desktop: error: value "/bin/sh -c '"$SHELL" -i -c scrcpy'" for key "Exec" in group "Desktop Entry" contains a non-escaped character '$' in a quote, but it should be escaped with two backslashes ("\\$")
scrcpy.desktop: error: value "/bin/sh -c '"$SHELL" -i -c scrcpy'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
scrcpy.desktop: hint: value item "RemoteAccess" in key "Categories" in group "Desktop Entry" can be extended with another category among the following categories: Network

scrcpy-console.desktop

$ desktop-file-validate scrcpy-console.desktop 
scrcpy-console.desktop: error: value "/bin/bash --norc --noprofile -i -c '"$SHELL" -i -c scrcpy || read -p "Press any key to quit..."'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
scrcpy-console.desktop: error: value "/bin/bash --norc --noprofile -i -c '"$SHELL" -i -c scrcpy || read -p "Press any key to quit..."'" for key "Exec" in group "Desktop Entry" contains a non-escaped character '$' in a quote, but it should be escaped with two backslashes ("\\$")
scrcpy-console.desktop: error: value "/bin/bash --norc --noprofile -i -c '"$SHELL" -i -c scrcpy || read -p "Press any key to quit..."'" for key "Exec" in group "Desktop Entry" contains a reserved character '|' outside of a quote
scrcpy-console.desktop: error: value "/bin/bash --norc --noprofile -i -c '"$SHELL" -i -c scrcpy || read -p "Press any key to quit..."'" for key "Exec" in group "Desktop Entry" contains a reserved character '|' outside of a quote
scrcpy-console.desktop: error: value "/bin/bash --norc --noprofile -i -c '"$SHELL" -i -c scrcpy || read -p "Press any key to quit..."'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
scrcpy-console.desktop: hint: value item "RemoteAccess" in key "Categories" in group "Desktop Entry" can be extended with another category among the following categories: Network
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant