Keyboard combinations for volume buttons conflict with Mac shortcuts

[numbermaniac]

scrcpy --help says that Control-Up and Control-Down are the commands for activating the volume buttons on the phone. However, these are unusable on Mac by default, because these keyboard shortcuts show you all open windows (control-up), and all the windows for the current application (control-down).

This means that scrcpy doesn't receive these keyboard shortcuts, therefore not simulating the volume button presses on the connected phone.

[rom1v]

Mwarf. I changed them from Ctrl++ and Ctrl+- because it did not work everywhere: #103.

I chose Ctrl+↑ and Ctrl+↓ because they are the shortcuts for VLC (on Linux at least). What are the VLC shortcut on MacOS?

[numbermaniac]

For VLC on Mac, the keyboard shortcuts for changing the volume are Command-Up and Command-Down.

[rom1v]

@numbermaniac Thank you for the info.

If you look at all the shortcuts for scrcpy, would you say that Ctrl should always be replaced by Command on MacOS? Or just for the volume?

[xinx1n]

Other shortcuts works well on my mac except the volume.
And by default：
Command-M: Minimize the front window to the Dock.
Command-H: Hide the windows of the front app.
So Ctrl should be replaced by Command on MacOS just for the volume.

[numbermaniac]

Yes, those two shortcuts are also built-in on Mac so they should be best kept as Control. Other shortcuts, though not conflicting with anything, might be confusing if changed to Command: Command-P usually means Print, Command-S usually means Save, Command-F for Find, and Command-B is sometimes used for Bold text.

As xinx1n said, it would probably be best to just replace Ctrl with Command for the volume buttons.

[rom1v]

Could you test the macos_volume branch, and tell me if it works correctly on MacOS, please?

[numbermaniac]

Do I need to go through the full client and server building instructions for this? Is there a pre-built server I can use?

[rom1v]

@numbermaniac It should work with the prebuilt server from v1.4: https://github.com/Genymobile/scrcpy/blob/macos_volume/BUILD.md#prebuilt-server

[xinx1n]

sry，I just get my macbook now.
I built the client and server and tested the shortcuts(only the shortcuts), it's ok.

[rom1v]

Merged on master (5bf1261 + d061c30).