Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support device resolution changes #161

Closed
LimSH0731 opened this issue May 31, 2018 · 5 comments
Closed

Support device resolution changes #161

LimSH0731 opened this issue May 31, 2018 · 5 comments

Comments

@LimSH0731
Copy link

LimSH0731 commented May 31, 2018

After decrease the resolution and resize window, the window will still leave a black space on the right and bottom. And show background screen beyond set screen size on home screen.

PC
OS: Windows 10 Pro
CPU : Intel core it-7700HQ
RAM : 8GB
GPU : GTX 1050 2GB

Phone
SM-N950N (Smasung Galaxy Note 8)
OS : Android 8.0.0

55565

@rom1v
Copy link
Collaborator

rom1v commented May 31, 2018

Does it also happen with v1.1?

@LimSH0731
Copy link
Author

This is screenshot with 1.1 v.
FHD -> WQHD

fhd-wqhd

WQHD -> FHD

wqhd-fhd

@rom1v
Copy link
Collaborator

rom1v commented May 31, 2018

After decrease the resolution and resize window

How do you decrease the resolution?

@LimSH0731
Copy link
Author

Samsung smartphones have that resolution change feature for saving battery or watching movie more clear. but, other smartphones can take this feature to 'ROOT'. So I think it is not problem only on Samsung.

@rom1v
Copy link
Collaborator

rom1v commented May 31, 2018

Samsung smartphones have that resolution change feature for saving battery or watching movie more clear.

OK, so it would require to listen to resolution changes in addition to orientation changes.

@rom1v rom1v changed the title Screen problems after adjusting the resolution. Support device resolution changes May 31, 2018
rom1v added a commit that referenced this issue Oct 28, 2024
Replace RotationWatcher and DisplayFoldListener by a single
DisplayListener, which is notified whenever the display size or dpi
changes.

Still use the old mechanism specifically for Android 14, where
DisplayListener may be broken (it is fixed in recent Android 14
upgrades), until we receive the first DisplayListener event (which
proves that it works).

Fixes #161 <#161>
Fixes #1918 <#1918>
Fixes #4152 <#4152>
Refs #4469 <#4469>

Co-authored-by: Simon Chan <[email protected]>
rom1v added a commit that referenced this issue Oct 28, 2024
Replace RotationWatcher and DisplayFoldListener by a single
DisplayListener, which is notified whenever the display size or dpi
changes.

Still use the old mechanism specifically for Android 14, where
DisplayListener may be broken (it is fixed in recent Android 14
upgrades), until we receive the first DisplayListener event (which
proves that it works).

Fixes #161 <#161>
Fixes #1918 <#1918>
Fixes #4152 <#4152>
Fixes #5362 comment <#5362 (comment)>
Refs #4469 <#4469>

Co-authored-by: Simon Chan <[email protected]>
rom1v added a commit that referenced this issue Oct 30, 2024
Replace RotationWatcher and DisplayFoldListener by a single
DisplayListener, which is notified whenever the display size or dpi
changes.

However, the DisplayListener mechanism is broken in the first versions
of Android 14 (it is fixed in android-14.0.0_r29 by commit [1]), so
continue to use the old mechanism specifically for Android 14 (where
DisplayListener may be broken), until we receive the first
"display changed" event (which proves that it works).

[1]: <https://android.googlesource.com/platform/frameworks/base.git/+/5653c6b5875df599307c3e6bfae32fb2fc17ca1f%5E%21/>

Fixes #161 <#161>
Fixes #1918 <#1918>
Fixes #4152 <#4152>
Fixes #5362 comment <#5362 (comment)>
Refs #4469 <#4469>
PR #5415 <#5415>

Co-authored-by: Simon Chan <[email protected]>
@rom1v rom1v closed this as completed in e26bdb0 Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants