System 1418/update network plugin #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can adjust widget layout and network profile items.
input list for mobile profile input list for signal strength
- edit 5g name (to be consistent with redis message) - unlimited item correspond to redis 'none' value.
version is >= 8. This is done when an item is selected on the list.
…ted on the list. Update mobile signal strength list UI when a new value is received with redis.
Remove default input values for snetwork type and signal strenth for android versions >= 8.0 Add a call to the sendDataToInstance method when profile changed Remove explicit calls to changeProfile
Also update screenshot with the new baseband widget icon.
cmajed
requested review from
caarmen,
gvercoutere-geny,
JulienBolard,
guillaume-roche and
pgivel
pgivel
requested changes
Dec 13, 2022
Some times settings redis message is received before capabilities in this cas the widget is not yet fully constructed.
JulienBolard
reviewed
Jan 4, 2023
JulienBolard
reviewed
Jan 4, 2023
guillaume-roche
suggested changes
Jan 5, 2023
caarmen
reviewed
Jan 5, 2023
| } | ||
|
|
||
| disable5G() { | ||
| // Nothing to do! |
There was a problem hiding this comment.
because the widget is constructed by default without 5G
if capability is true we add it if its fals we have nothing to do
caarmen
reviewed
Jan 6, 2023
guillaume-roche
approved these changes
Jan 9, 2023
gvercoutere-geny
approved these changes
Jan 9, 2023
pgivel
approved these changes
Jan 10, 2023
caarmen
reviewed
Jan 11, 2023
caarmen
reviewed
Jan 11, 2023
caarmen
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Network widget to:
Fixes #https://genymobile.atlassian.net/browse/SYSTEM-1418
Type of change
Checklist