-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test to make sure PyGMT works with paths that contain non-ASCII characters #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
changed the title
Add a test to make sure PyGMT works with paths that contain non-ASCII characters
WIP: Add a test to make sure PyGMT works with paths that contain non-ASCII characters
May 29, 2024
seisman
changed the title
WIP: Add a test to make sure PyGMT works with paths that contain non-ASCII characters
Add a test to make sure PyGMT works with paths that contain non-ASCII characters
Jul 24, 2024
weiji14
approved these changes
Jul 28, 2024
seisman
added
final review call
This PR requires final review and approval from a second reviewer
and removed
needs review
This PR has higher priority and needs review.
final review call
This PR requires final review and approval from a second reviewer
labels
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds a new test to check if PyGMT works on a user account that has non-ASCII characters (e.g., Chinese characters). The issue is initially reported in #3279.
It turns out GMT and PyGMT work well on Linux/macOS, but don't work on Windows. On Windows, the errors are like:
There are two main issues:
gmt_mkdir
reports errors "Invalid argument"(null)/gmt_data_server.txt
is incorrect, which meansGMT->session.USERDIR=NULL
It's because when
gmt_mkdir
fails, GMT freesGMT->session.USERDIR
(https://github.com/GenericMappingTools/gmt/blob/1c8a78b0613a227f406303930ebcf7238ad3401d/src/gmt_init.c#L3826). ChatGPT told me that themkdir
function on Windows doesn't support multi-byte characters. So I guess that's the reason and the test is skipped on Windows (I may find some time debugging this in the future but not now).