Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.savefig: Support saving figures in PPM (.ppm) format #2771

Merged
merged 4 commits into from
Oct 28, 2023
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 26, 2023

Description of proposed changes

Support PPM format and also sort formats alphabetically.

Preview: https://pygmt-dev--2771.org.readthedocs.build/en/2771/api/generated/pygmt.Figure.savefig.html

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the enhancement Improving an existing feature label Oct 26, 2023
@seisman seisman changed the title Figure.savefig: Support PPM (.ppm) format Figure.savefig: Support saving figures in PPM (.ppm) format Oct 26, 2023
@seisman seisman added this to the 0.11.0 milestone Oct 26, 2023
@seisman seisman added the needs review This PR has higher priority and needs review. label Oct 26, 2023
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Oct 27, 2023
@seisman seisman merged commit 6cc61d3 into main Oct 28, 2023
15 checks passed
@seisman seisman deleted the savefig/ppm branch October 28, 2023 13:04
@seisman seisman added feature Brand new feature and removed final review call This PR requires final review and approval from a second reviewer enhancement Improving an existing feature labels Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants