-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure.meca: Fix beachball offsetting for ndarray input (requires GMT>=6.5.0) #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
changed the title
WIP: Figure.meca: Fix the beachball offsetting for ndarray input
Figure.meca: Fix the beachball offsetting for ndarray input
Jun 24, 2023
seisman
changed the title
Figure.meca: Fix the beachball offsetting for ndarray input
Figure.meca: Fix beachball offsetting for ndarray input
Jun 24, 2023
seisman
force-pushed
the
meca/offset-ndarray
branch
from
June 24, 2023 14:07
509a790
to
e109880
Compare
seisman
force-pushed
the
meca/offset-ndarray
branch
from
June 24, 2023 14:22
0bb5788
to
cc74814
Compare
seisman
added
upstream
Bug or missing feature of upstream core GMT
needs review
This PR has higher priority and needs review.
labels
Jun 24, 2023
seisman
changed the title
Figure.meca: Fix beachball offsetting for ndarray input
Figure.meca: Fix beachball offsetting for ndarray input (requires GMT>=6.5.0)
Jun 28, 2023
michaelgrund
approved these changes
Jul 6, 2023
Co-authored-by: Michael Grund <[email protected]>
seisman
added
final review call
This PR requires final review and approval from a second reviewer
and removed
needs review
This PR has higher priority and needs review.
labels
Jul 6, 2023
seisman
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Jul 8, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Changes in this PR:
data_format_code
toconvention_code
and update docstringsconvention_name
which determine the convention name (e.g.,"aki"
) from convention code (e.g.,"a"
)convention_params
to return the list of focal parametersFigure.meca
method to make it work with ndarray input.Offsetting beachballs for ndarray input requires GMT>=6.5, due to an upstream bug fixed in GenericMappingTools/gmt#7557.
Fixes #2016
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version