Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.psconvert: Check if the given prefix is valid #2170

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 21, 2022

Description of proposed changes

For Figure.psconvert, prefix can't be "", None, True or False.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman force-pushed the pscovert-invalid-prefix branch from 50421be to 5de1f78 Compare October 21, 2022 05:56
@seisman seisman added the enhancement Improving an existing feature label Oct 21, 2022
@seisman seisman added this to the 0.8.0 milestone Oct 21, 2022
@seisman seisman requested a review from weiji14 October 22, 2022 01:35
@seisman seisman added the needs review This PR has higher priority and needs review. label Oct 27, 2022
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems more like a user error if they're passing these ("", None, False or True) values to psconvert's -F/prefix. But code and tests look ok.

@weiji14 weiji14 added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Oct 27, 2022
@seisman seisman merged commit bd05e70 into main Oct 28, 2022
@seisman seisman deleted the pscovert-invalid-prefix branch October 28, 2022 03:08
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants