Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP29: Set minimum required version to NumPy 1.20+ #1985

Merged
merged 2 commits into from
Jul 2, 2022
Merged

Conversation

maxrjones
Copy link
Member

@maxrjones maxrjones commented Jul 2, 2022

Description of proposed changes

Following NEP29 policy where NumPy 1.19 is to be dropped on or after June. 21, 2022 (in a minor version increment, i.e. for PyGMT v0.7.0). Bumps minimum supported NumPy version to 1.20 in the setup.py, requirements.txt and environment.yml files. Also update installation documentation and set CI tests to run on NumPy 1.20.

xref #1675

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones maxrjones added maintenance Boring but important stuff for the core devs deprecation Deprecating a feature and removed maintenance Boring but important stuff for the core devs labels Jul 2, 2022
@weiji14 weiji14 mentioned this pull request Jul 2, 2022
8 tasks
@maxrjones maxrjones mentioned this pull request Jul 2, 2022
26 tasks
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, as long as the tests pass, just need to update the required tests to use Python 3.8 / NumPy 1.20. Thanks Max!

@maxrjones maxrjones merged commit 1b5a60d into main Jul 2, 2022
@maxrjones maxrjones deleted the drop-numpy1.19 branch July 2, 2022 00:56
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@weiji14 weiji14 added this to the 0.7.0 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants