Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up functions for loading datasets #1955

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

willschlitzer
Copy link
Contributor

As mentioned by @seisman in this comment, this splits up the dictionaries for loading functions between the public facing functions and the private ones. It eliminates the need to have the new dataset functions accept **kwargs.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the enhancement Improving an existing feature label Jun 13, 2022
@willschlitzer willschlitzer added this to the 0.7.0 milestone Jun 13, 2022
@willschlitzer willschlitzer self-assigned this Jun 13, 2022
@seisman seisman added maintenance Boring but important stuff for the core devs final review call This PR requires final review and approval from a second reviewer and removed enhancement Improving an existing feature labels Jun 13, 2022
@seisman seisman merged commit 2febc8f into main Jun 14, 2022
@seisman seisman deleted the split-sample-data-functions branch June 14, 2022 13:11
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 14, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants