-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap dimfilter #1492
Wrap dimfilter #1492
Conversation
Sorry for keeping you waiting on a review for this module! dimfilter will be a great addition to the PyGMT processing modules 🎉 I am hoping to find time to check out the branch within the next week. |
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor docstring comments. The implementation looks quite good already, and we could merge this new feature 'soon' after a final review, but it'll depend on whether we want to do a PyGMT v0.6.1 or jump straight to PyGMT v0.7.0.
I say we wait until the end of March 2022, and if there isn't any major bug that pops up with users using PyGMT v0.6.0, then we'll jump straight to v0.7.0. What do you think?
Co-authored-by: Wei Ji <[email protected]>
That's fine with me; I'm just hoping to get this wrapped up relatively soon since it's been an open for 6 months. |
I agree. |
@GenericMappingTools/pygmt-maintainers Are we still holding off for v0.6.1 or am I good to merge this? |
We will release v0.6.1 soon #1856. |
Co-authored-by: Meghan Jones <[email protected]> Co-authored-by: Dongdong Tian <[email protected]> Co-authored-by: Wei Ji <[email protected]>
This pull request wraps the function
dimfilter
.Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version