Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pygmt with GMT master branch #345

Closed
seisman opened this issue Oct 12, 2019 · 2 comments · Fixed by #485
Closed

Test pygmt with GMT master branch #345

seisman opened this issue Oct 12, 2019 · 2 comments · Fixed by #485
Labels
maintenance Boring but important stuff for the core devs
Milestone

Comments

@seisman
Copy link
Member

seisman commented Oct 12, 2019

Currently, we test pygmt with GMT 6.0.0rc4. I think we also need to test pygmt with the GMT master branch, to make sure changes in the core GMT don't break pygmt.

@seisman seisman added the maintenance Boring but important stuff for the core devs label Oct 12, 2019
@weiji14
Copy link
Member

weiji14 commented Mar 11, 2020

Continuing on the discussion from #397, I'm just throwing out some options here. In order of least to most work, do we want to:

  1. Just test against master on Linux (i.e. only edit the .travis.yml file), basically Build GMT master instead of using conda-forge #261 all over again.
  2. Test on all platforms (Linux, MacOS, Windows and edit both .travis.yml and .azure-pipelines.yml
  3. Refactor our test suite completely, and maybe consolidate our tests into one platform in one go:
    a) Follow core GMT and put everything in the azure-pipelines.yml file. See Enable Linux CI on azure pipelines gmt#988.
    b) Go the Github Actions build matrix route, to test multiple platforms/Python versions. See also https://github.com/marketplace/actions/setup-miniconda.

As a side note, do we want to be testing for compatibility against multiple GMT versions in the long run (e.g. 6.0, 6.1, 6.2, etc?).

@seisman
Copy link
Member Author

seisman commented Mar 18, 2020

Ideally, we should test multiple GMT versions for compatibility. However, it seems difficult to maintain.

Sometimes, different GMT versions may produce slightly different images (e.g. a bug in 6.0.0, but fixed in 6.1.0), but the pygmt testing mechanism can only have one baseline image. Thus some pygmt tests must be failing for at least one GMT version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants