Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint 3.0.0 reports cyclic-import errors #2712

Closed
seisman opened this issue Oct 3, 2023 · 0 comments · Fixed by #2713
Closed

pylint 3.0.0 reports cyclic-import errors #2712

seisman opened this issue Oct 3, 2023 · 0 comments · Fixed by #2713
Labels
maintenance Boring but important stuff for the core devs
Milestone

Comments

@seisman
Copy link
Member

seisman commented Oct 3, 2023

First reported in #2709 (comment).

With the latest pylint 3.0.0 (https://github.com/pylint-dev/pylint/releases/tag/v3.0.0), the style checks workflow now reports the following errors:

Run make lint
pylint pygmt doc/conf.py
************* Module conf
doc/conf.py:1:0: R0401: Cyclic import (pygmt -> pygmt.src -> pygmt.src.timestamp) (cyclic-import)
doc/conf.py:1:0: R0401: Cyclic import (pygmt -> pygmt.src -> pygmt.src.ternary) (cyclic-import)
doc/conf.py:1:0: R0401: Cyclic import (pygmt -> pygmt.figure -> pygmt.src.timestamp) (cyclic-import)
doc/conf.py:1:0: R0401: Cyclic import (pygmt -> pygmt.figure -> pygmt.src.ternary) (cyclic-import)

-----------------------------------
Your code has been rated at 9.99/10

make: *** [Makefile:79: lint] Error 8
Error: Process completed with exit code 2.

The cyclic-import errors are caused by the __gmt_version__ variable added in #2366.

@seisman seisman added bug Something isn't working maintenance Boring but important stuff for the core devs labels Oct 3, 2023
@seisman seisman added this to the 0.11.0 milestone Oct 3, 2023
@seisman seisman removed the bug Something isn't working label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant