Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Four tilemap tests fail likely due to upstream changes #2699

Closed
seisman opened this issue Sep 22, 2023 · 2 comments
Closed

Four tilemap tests fail likely due to upstream changes #2699

seisman opened this issue Sep 22, 2023 · 2 comments
Labels
maintenance Boring but important stuff for the core devs
Milestone

Comments

@seisman
Copy link
Member

seisman commented Sep 22, 2023

See the failures in the recent CI runs: https://github.com/GenericMappingTools/pygmt/actions/runs/6270258961/job/17027947064

Here is one failing test:

Expected Actual
baseline result

Likely some changes in the original tiff files returned from the tile server?

@seisman seisman added the triage Unsure where this issue fits label Sep 22, 2023
@weiji14
Copy link
Member

weiji14 commented Sep 22, 2023

Likely some changes in the original tiff files returned from the tile server?

Ah yes, Stamen has moved their tiles to Stadia and that came with a bit of a redesign, see https://stamen.com/here-comes-the-future-of-stamen-maps. We should also see what contextily is doing - geopandas/contextily#220, or switch to a non-Stamen basemap (that is somewhat stable) for the unit tests.

@seisman seisman added maintenance Boring but important stuff for the core devs and removed triage Unsure where this issue fits labels Sep 22, 2023
@seisman seisman added this to the 0.11.0 milestone Sep 22, 2023
@weiji14
Copy link
Member

weiji14 commented Sep 27, 2023

We'll also need to change the second example at https://www.pygmt.org/v0.10.0/gallery/maps/tilemaps.html that uses Stamen Watercolor, after Stamen stops redirecting to Stadia's servers on 31 October 2023 according to https://maps.stamen.com/stadia-partnership.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

No branches or pull requests

2 participants