Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.show: raise warnings if dpi or width are used with method=external or method=none #2449

Closed
seisman opened this issue Mar 21, 2023 · 1 comment
Labels
enhancement Improving an existing feature wontfix This will not be worked on

Comments

@seisman
Copy link
Member

seisman commented Mar 21, 2023

Do you think that there should be warnings if dpi or width are used with method=external or method=none?

Originally posted by @maxrjones in #529 (review)

Sounds good to me. I will open a separate PR about dpi and width settings after this PR is merged.

Originally posted by @seisman in #529 (comment)

@seisman seisman added the enhancement Improving an existing feature label Mar 21, 2023
@seisman
Copy link
Member Author

seisman commented Apr 11, 2023

I'm closing the issue, because in the current implementation, both dpi and width have default values (300 and 500, respectively), so we really can't know if users specify their own dpi and width with method="external" or method="none".

@seisman seisman closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2023
@seisman seisman added the wontfix This will not be worked on label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant