Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite gallery example "track_sampling.py" #2282

Closed
yvonnefroehlich opened this issue Dec 28, 2022 · 3 comments · Fixed by #2515
Closed

Rewrite gallery example "track_sampling.py" #2282

yvonnefroehlich opened this issue Dec 28, 2022 · 3 comments · Fixed by #2515
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@yvonnefroehlich
Copy link
Member

yvonnefroehlich commented Dec 28, 2022

Original posts by @weiji14 (#2190 (review)) and @seisman (#2190 (comment)) regarding gallery example track_sampling.py:

The original intention of the track_sampling.py gallery example added in #308 was to showcase the grdtrack data processing function, rather than as a proper 'map' per se.

Personally, I feel that having just one colorbar (the normalized elevation one) would be enough, since the background grayscale earth_relief elevation is just for context. But I also find normalized elevation to be hard to interpret (see my comment below), so not sure what's a good plan forward 😅 What are your thoughts?

Perhaps we can rewrite the grdtrack example to something like (https://docs.gmt-china.org/latest/examples/ex026/):
image

@yvonnefroehlich yvonnefroehlich added the documentation Improvements or additions to documentation label Dec 28, 2022
@yvonnefroehlich yvonnefroehlich added this to the 0.9.0 milestone Dec 28, 2022
@weiji14 weiji14 added the help wanted Helping hands are appreciated label Dec 28, 2022
@seisman seisman modified the milestones: 0.9.0, 0.10.0 Mar 19, 2023
@yvonnefroehlich
Copy link
Member Author

Do we simply want to re-write the example at https://docs.gmt-china.org/latest/examples/ex026/ to PyGMT, or are there some ideas on how to change the existing gallery example track_sampling.py?

@weiji14
Copy link
Member

weiji14 commented Apr 23, 2023

Do we simply want to re-write the example at https://docs.gmt-china.org/latest/examples/ex026/ to PyGMT, or are there some ideas on how to change the existing gallery example track_sampling.py?

Yes, it would be good to add ex026 as a new example for making cross-section plots along a transect. I would prefer to keep the existing track_sampling.py example intact if possible (because it's been surprisingly useful for catching bugs in the past, see e.g. #531), but no strong opinions on simply modifying it.

@yvonnefroehlich
Copy link
Member Author

Do we simply want to re-write the example at https://docs.gmt-china.org/latest/examples/ex026/ to PyGMT, or are there some ideas on how to change the existing gallery example track_sampling.py?

Yes, it would be good to add ex026 as a new example for making cross-section plots along a transect.

I started working on this in PR #2515.

I would prefer to keep the existing track_sampling.py example intact if possible (because it's been surprisingly useful for catching bugs in the past, see e.g. #531), but no strong opinions on simply modifying it.

From my side we can keep the track_sampling.py example. Just got the impression, that we want either the track_sampling.py example or the one from https://docs.gmt-china.org/latest/examples/ex026/.

@seisman seisman removed the help wanted Helping hands are appreciated label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants