Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov GitHub checks not running? #1482

Closed
weiji14 opened this issue Sep 3, 2021 · 1 comment · Fixed by #1494
Closed

Codecov GitHub checks not running? #1482

weiji14 opened this issue Sep 3, 2021 · 1 comment · Fixed by #1494
Labels
maintenance Boring but important stuff for the core devs
Milestone

Comments

@weiji14
Copy link
Member

weiji14 commented Sep 3, 2021

Description of the problem

Not sure what happened to the codecov status checks... It seems to have disappeared from recent PRs. The most recent merged PR I found with the status check intact was on 10 August 2021 at #1426. Anyone know what's up? Was there a recent change that requires modifying the config file at https://github.com/GenericMappingTools/pygmt/blob/v0.4.1/.github/codecov.yml?

Ref: https://docs.codecov.com/docs/github-checks

image

Edit: Might have something to do with the CodeCov Bash Uploader Deprecation Plan at https://about.codecov.io/blog/codecov-uploader-deprecation-plan/. Need to investigate more.

@weiji14 weiji14 added question Further information is requested maintenance Boring but important stuff for the core devs labels Sep 3, 2021
@weiji14
Copy link
Member Author

weiji14 commented Sep 14, 2021

Thanks @seisman and @meghanrjones, the Codecov GitHub App integration is back on https://github.com/GenericMappingTools/pygmt/settings/installations:

image

I'll add back the codecov diff check as a required status check later (edit: done!), and maybe tweak #1494 a bit since there are a few things we can use inside.

@seisman seisman added this to the 0.5.0 milestone Sep 17, 2021
@seisman seisman removed the question Further information is requested label Sep 17, 2021
@weiji14 weiji14 changed the title Codecov GItHub checks not running? Codecov GitHub checks not running? Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants