Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in the source code and documentation #1361

Closed
seisman opened this issue Jun 26, 2021 · 7 comments · Fixed by #1363
Closed

Typos in the source code and documentation #1361

seisman opened this issue Jun 26, 2021 · 7 comments · Fixed by #1363
Labels
documentation Improvements or additions to documentation first-timers-only For absolute beginners good first issue Good for newcomers
Milestone

Comments

@seisman
Copy link
Member

seisman commented Jun 26, 2021

Description of the problem

Here are some small typos in the source code and documentation, which are easy to fix.


PyGMT is still undergoing rapid developement. All of the API is subject to change

Line 174 in doc/maintenance.md: "developement" should be "development".


and nightime. The parameter ``terminator`` is used to set the twilight stage, and can be

Line 6 in examples/gallery/embellishments/solar.py: "nightime" should be "nighttime".


# of a business quarter as denoted by BQS when passed to the ``periods`` parameter. The inital

Line 158 in examples/tutorials/date_time_charts.py: "inital" should be "initial".


# dataset before passing it as a paramater. However, ``np.array`` objects use less

Line 210 in examples/tutorials/date_time_charts.py: "paramater" should be "parameter".


# vectors, use ``=`` at the begining of the ``style`` parameter.

Line 352 in examples/tutorials/vectors.py: "begining" should be "beginning".


Plot the histogram using horizonal bars instead of the

Line 101 in pygmt/src/histogram.py: "horizonal" should be "horizontal".

@seisman seisman added good first issue Good for newcomers documentation Improvements or additions to documentation first-timers-only For absolute beginners labels Jun 26, 2021
@Jayita10
Copy link

I am trying to learn how open source work. Can I work on this issue?

@Jayita10
Copy link

@soham4abc good gesture from you :)

@soham4abc
Copy link
Contributor

soham4abc commented Jun 27, 2021

@soham4abc good gesture from you :)

I am so sorry! I did not see anyone assigned yet to this issue, thus I made a PR. I will be closing my pull Request! Please feel Free to contribute! Welcome to open source!

@soham4abc
Copy link
Contributor

@Jayita10 go ahead its yours's!

@Jayita10
Copy link

Nopes @soham4abc, neither I am assigned to this task. You please reopen your PR.
For the next time, make sure to check whether anyone claim for the issue or not before making a PR. Thanks :)

@soham4abc soham4abc mentioned this issue Jun 27, 2021
5 tasks
@soham4abc
Copy link
Contributor

Nopes @soham4abc, neither I am assigned to this task. You please reopen your PR.
For the next time, make sure to check whether anyone claim for the issue or not before making a PR. Thanks :)

Done! And once again, sorry!

@seisman
Copy link
Member Author

seisman commented Jun 27, 2021

@soham4abc Thanks for your quick contribution.

@Jayita10 We may find another easy issue for you.

@seisman seisman added this to the 0.5.0 milestone Jun 27, 2021
@seisman seisman modified the milestones: 0.5.0, 0.4.1 Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation first-timers-only For absolute beginners good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants