Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if options is NULL rather than options->option #8593

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 6, 2024

Description of proposed changes

Address #8592 (comment).
Patches #8592.

@seisman seisman requested a review from joa-quim October 6, 2024 08:23
Copy link
Member

@joa-quim joa-quim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but this was not changed in #8593. It’s here for quiet some time (if I remember well).

@seisman
Copy link
Member Author

seisman commented Oct 6, 2024

@seisman seisman merged commit 5bde2b2 into master Oct 6, 2024
15 of 18 checks passed
@seisman seisman deleted the fix-options branch October 6, 2024 10:21
@joa-quim
Copy link
Member

joa-quim commented Oct 6, 2024

Ah, I remember a bit better now (I’m on mobile, cannot use tools). I had a previous older change in my local file. The +n in triangulate had nothing to do with it. But still strange that I hadn’t made a separate PR got it. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants