Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the default stars grayed out ONLY ON UI #53

Open
MoeNick opened this issue Sep 27, 2024 · 12 comments
Open

Make the default stars grayed out ONLY ON UI #53

MoeNick opened this issue Sep 27, 2024 · 12 comments
Assignees

Comments

@MoeNick
Copy link
Contributor

MoeNick commented Sep 27, 2024

We have 3 stars as default, we should only make them colored if the user has voted on them before, so if the user has not voted on them yet, we should show it grayed out.

Note that in the backend 3 stars will be like before as default value.

@MoeNick MoeNick changed the title Make the default stars grayed out Make the default stars grayed out ONLY ON UI Sep 27, 2024
@MoeNick
Copy link
Contributor Author

MoeNick commented Sep 27, 2024

Can you make it quickly @Meriem-BM

@MoeNick
Copy link
Contributor Author

MoeNick commented Sep 27, 2024

Please before merging let @mmahdigh take a look and review and tag me as well.

@MoeNick
Copy link
Contributor Author

MoeNick commented Sep 29, 2024

@Meriem-BM gm
@GriffGreen asked to merge this with high priority please
Cc: @mmahdigh

@Meriem-BM
Copy link
Collaborator

@mmahdigh can you explain me this please? how to know if a user already voted for a specific project?

@mmahdigh
Copy link
Collaborator

@mmahdigh can you explain me this please? how to know if a user already voted for a specific project?

Sure. The projects which haven't been rated before have a null value as their rating. (As opposed to rated projects which have a 1 to 5 number as their rating)

@Meriem-BM
Copy link
Collaborator

@mmahdigh can you explain me this please? how to know if a user already voted for a specific project?

Sure. The projects which haven't been rated before have a null value as their rating. (As opposed to rated projects which have a 1 to 5 number as their rating)

Thanks, but if I undo my selection, the rating goes back as null as well, is that excepted?

@MoeNick
Copy link
Contributor Author

MoeNick commented Sep 29, 2024

If the last action was starring a null rated project, yes.

@maryjaf
Copy link

maryjaf commented Sep 29, 2024

Screen.Recording.2024-09-29.at.4.21.57.PM.mov

the first guide modal isn't shown @Meriem-BM

@Meriem-BM
Copy link
Collaborator

Meriem-BM commented Sep 29, 2024

Screen.Recording.2024-09-29.at.4.21.57.PM.mov
the first guide modal isn't shown @Meriem-BM

Yeah that was a small bug I just made a fix, you can check now

@maryjaf
Copy link

maryjaf commented Sep 30, 2024

Screen.Recording.2024-09-30.at.6.35.02.PM.mov

if I set stars for the project and then tap on conflict , for the next project these stars are shown

Screen.Recording.2024-09-30.at.6.35.02.PM.mov

@Meriem-BM

@Meriem-BM
Copy link
Collaborator

Screen.Recording.2024-09-30.at.6.35.02.PM.mov
if I set stars for the project and then tap on conflict , for the next project these stars are shown

Screen.Recording.2024-09-30.at.6.35.02.PM.mov
@Meriem-BM

Thanks for catching that, the fix is on staging now @maryjaf

@maryjaf
Copy link

maryjaf commented Sep 30, 2024

Screen.Recording.2024-09-30.at.6.35.02.PM.mov
if I set stars for the project and then tap on conflict , for the next project these stars are shown
Screen.Recording.2024-09-30.at.6.35.02.PM.mov
@Meriem-BM

Thanks for catching that, the fix is on staging now @maryjaf

Thanks @Meriem-BM it has been fixed on staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged on Production
Development

No branches or pull requests

4 participants