Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo effect #19

Open
MoeNick opened this issue Sep 22, 2024 · 5 comments
Open

Undo effect #19

MoeNick opened this issue Sep 22, 2024 · 5 comments
Assignees
Labels
P1 finish this task to unblock someone else, required to be done before other things

Comments

@MoeNick
Copy link
Contributor

MoeNick commented Sep 22, 2024

As a user, I want to see an effect on UNDO action to understand if my last action was UNDO or is in the UNDing process.

Description: The user should see the rewind modal effect for a second, while the background is faded out. All UNdo actions can be done during that time if it takes more than one sec, we can keep this modal unless and error happens. In the case of error, we can close the modal, so the user can try again.
Image

Design Resources: https://www.figma.com/design/WTT6ygvEonijX7Lc0pj6Ru/Pairwise-Desktop-App?node-id=1288-29377&t=J23PDc9U8UAnBwjW-4

@MoeNick MoeNick added the P1 finish this task to unblock someone else, required to be done before other things label Sep 22, 2024
@Meriem-BM Meriem-BM assigned Meriem-BM and unassigned mmahdigh Sep 22, 2024
@Meriem-BM
Copy link
Collaborator

I added this modal in my last PR if you can check @MoeNick, @maryjaf

@maryjaf
Copy link

maryjaf commented Sep 23, 2024

undo modal is added

Screen.Recording.2024-09-23.at.12.25.26.PM.mov

@maryjaf
Copy link

maryjaf commented Sep 24, 2024

when I tap on undo until the first comparison , this modal remains and I can't be able to close it and I should refresh the page
@Meriem-BM

Screen.Recording.2024-09-24.at.4.11.19.PM.mov

@Meriem-BM
Copy link
Collaborator

when I tap on undo until the first comparison , this modal remains and I can't be able to close it and I should refresh the page @Meriem-BM

Screen.Recording.2024-09-24.at.4.11.19.PM.mov

Can you test this now @maryjaf

@maryjaf
Copy link

maryjaf commented Sep 25, 2024

Thanks @Meriem-BM it has been fixed

Screen.Recording.2024-09-25.at.5.26.12.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 finish this task to unblock someone else, required to be done before other things
Projects
Status: Merged on Production
Development

No branches or pull requests

4 participants