Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ballot flow #11

Open
4 tasks done
MoeNick opened this issue Sep 2, 2024 · 7 comments
Open
4 tasks done

Update ballot flow #11

MoeNick opened this issue Sep 2, 2024 · 7 comments
Assignees

Comments

@MoeNick
Copy link
Contributor

MoeNick commented Sep 2, 2024

As a user when Im done with the ranking, pairwise should show me the unlock ballot and then update the user's ballot.
Image
Image
Image
Image

Draft Design: https://www.figma.com/design/WTT6ygvEonijX7Lc0pj6Ru/Pairwise-Desktop-App?node-id=1017-31884&t=yCfCnkr8lYXdpBdP-4
Will move to dev handoff and the copy will get updated.

Success Criteria:

  • it should update the user's ballot successfully and get back to this address https://develop-op-voting.up.railway.app/ballot all the ranked projects from pairwise should be there with correct percentages.
  • Loading should appear before success while waiting for the response.
  • Success modal when we got success from Agora API should shown. the link should open up the https://develop-op-voting.up.railway.app/ballot link in that
  • Error modal will shown if the user isn't able to update the ballot.
@MoeNick MoeNick added P0 the site is down and all work stops, until this issue is resolved. and removed P0 the site is down and all work stops, until this issue is resolved. labels Sep 17, 2024
@mmahdigh
Copy link
Collaborator

This is also ready to be tested. @maryjaf @MoeNick

@mmahdigh mmahdigh mentioned this issue Sep 18, 2024
@MoeNick
Copy link
Contributor Author

MoeNick commented Sep 18, 2024

@mmahdigh
Copy link
Collaborator

No worries. I believe they are already taken care of as I implemented them using the new designs from the get-go.

@maryjaf
Copy link

maryjaf commented Sep 24, 2024

  • when my ballot has been completed the flow works as expected and I see below modal

Image

  • but when I complete the comparison flow but the ballot hasn't been completed, when I login again with this user I got 502 error

0x0A82aB8ecBcb390396ddAE536F9F64371A6e5243
https://github.com/user-attachments/assets/23127a9c-ac93-4066-ba7d-837ba51b0eca

@mmahdigh

@mmahdigh
Copy link
Collaborator

  • when my ballot has been completed the flow works as expected and I see below modal

Image

  • but when I complete the comparison flow but the ballot hasn't been completed, when I login again with this user I got 502 error

0x0A82aB8ecBcb390396ddAE536F9F64371A6e5243 https://github.com/user-attachments/assets/23127a9c-ac93-4066-ba7d-837ba51b0eca

@mmahdigh

Yeah, very weird. I think that's fixed now though. If not, please attach the console logs.

@maryjaf
Copy link

maryjaf commented Sep 25, 2024

Yeah, very weird. I think that's fixed now though. If not, please attach the console logs.

Screen.Recording.2024-09-25.at.10.31.57.AM.mov

@maryjaf
Copy link

maryjaf commented Sep 25, 2024

Yeah, very weird. I think that's fixed now though. If not, please attach the console logs.

Screen.Recording.2024-09-25.at.10.31.57.AM.mov

this problem has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged on Production
Development

No branches or pull requests

3 participants