Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base-image version to ubuntu:24.04 #663

Open
Taepper opened this issue Dec 17, 2024 · 2 comments · May be fixed by #666
Open

Update base-image version to ubuntu:24.04 #663

Taepper opened this issue Dec 17, 2024 · 2 comments · May be fixed by #666
Assignees
@Taepper

Comments

@Taepper
Copy link
Collaborator

Taepper commented Dec 17, 2024

We are currently on ubuntu:22.04. For example this limits our gcc features, as that image version uses gcc 11.4.0 whereas the new long-term-support ubuntu image (ubuntu:24.04) provides gcc 13.3.0

When this is done, our uses of std::find_if should be changed to std::ranges::find_if to match our code style
@Taepper Taepper linked a pull request Dec 18, 2024 that will close this issue
Open
2 tasks
@Taepper
Copy link
Collaborator Author

Taepper commented Jan 6, 2025

It would be good to get this done before: actions/runner-images#10636

While not necessary, it will lead to less complexity in our setup. Normally, all our actions run in a docker container anyways, which makes this not really urgent. However, the change-list linting in our CI does run clang-tidy on our code directly from the CI container (using ubuntu-latest)

@Taepper
Copy link
Collaborator Author

Taepper commented Jan 6, 2025

Unfortunately, there are some errors when installing conan the same way we did before:

 > [3/7] RUN pip install conan==2.8.1:                                                                                                                                                                                               
0.254 error: externally-managed-environment                                                                                                                                                                                          
0.254                                                                                                                                                                                                                                
0.254 × This environment is externally managed                                                                                                                                                                                       
0.254 ╰─> To install Python packages system-wide, try apt install
0.254     python3-xyz, where xyz is the package you are trying to
0.254     install.
0.254     
0.254     If you wish to install a non-Debian-packaged Python package,
0.254     create a virtual environment using python3 -m venv path/to/venv.
0.254     Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
0.254     sure you have python3-full installed.
0.254     
0.254     If you wish to install a non-Debian packaged Python application,
0.254     it may be easiest to use pipx install xyz, which will manage a
0.254     virtual environment for you. Make sure you have pipx installed.
0.254     
0.254     See /usr/share/doc/python3.12/README.venv for more information.
0.254 
0.254 note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
0.254 hint: See PEP 668 for the detailed specification.

it is suggested to instead directly install python3-conan, which is not possible, as python3-conan is not on the ubuntu package list. (unlike python3-pip, which we already installed this way before)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Taepper Taepper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade base image GenSpectrum/LAPIS-SILO
1 participant
@Taepper