fix: bug when filtering for indexedStringColumns which are not presen…

…t in some partitions
GenSpectrum · Oct 26, 2023 · 62d4e08 · 62d4e08
1 parent 8ed14c3
commit 62d4e08
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/endToEndTests/test/queries/divisionFilter.json b/endToEndTests/test/queries/divisionFilter.json
@@ -0,0 +1,24 @@
+{
+  "testCaseName": "Filter by division then aggregate",
+  "query": {
+    "action": {
+      "limit": 100,
+      "type": "Aggregated"
+    },
+    "filterExpression": {
+      "children": [
+        {
+          "column": "division",
+          "value": "Aargau",
+          "type": "StringEquals"
+        }
+      ],
+      "type": "And"
+    }
+  },
+  "expectedQueryResult": [
+    {
+      "count": 6
+    }
+  ]
+}
diff --git a/src/silo/storage/column/indexed_string_column.cpp b/src/silo/storage/column/indexed_string_column.cpp
@@ -15,7 +15,7 @@ IndexedStringColumnPartition::IndexedStringColumnPartition(
 std::optional<const roaring::Roaring*> IndexedStringColumnPartition::filter(const std::string& value
 ) const {
    const auto value_id = lookup.getId(value);
-   if (value_id.has_value()) {
+   if (value_id.has_value() && indexed_values.contains(value_id.value())) {
       return &indexed_values.at(value_id.value());
    }
    return std::nullopt;