Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing react packager after travis addition #36

Closed
vongohren opened this issue May 24, 2017 · 4 comments
Closed

Failing react packager after travis addition #36

vongohren opened this issue May 24, 2017 · 4 comments

Comments

@vongohren
Copy link

vongohren commented May 24, 2017

This commit 82526c8 gives an error in react packager when using this library @Jasbir23

It complaines about duplicate module name with react and react-native.
This issue kinda explaines it: aksonov/react-native-router-flux#1809

So i believe after you added react-native and react as dependencies for your travis tests, it breaks now for simple usage of the library.

This might be solved with removing dependencies that is just for tests, and added them to devDependencies rather than the dependencies object.

@Jasbir23
Copy link
Contributor

Thanks for the input here @vongohren, Looking into this.

@Jasbir23
Copy link
Contributor

Hey @vongohren I hope this fixes it 4e3f891

@vongohren
Copy link
Author

Looks promising, cant confirm until friday though :(

@vongohren
Copy link
Author

I can confirm it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants