Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Use theme to turn off uppercase buttons on Android #1235

Closed
randomjunk opened this issue Sep 17, 2017 · 1 comment
Closed

Comments

@randomjunk
Copy link

NativeBase enforces uppercase on Buttons when not on iOS here.

Unfortunately there's no way to disable this behaviour other than by adding <Text uppercase={false}> every time we create a Button, which is messy and easily forgotten, or creating a wrapper component to do that, which is also easily forgotten.

I looked into disabling via the theme or via variables, but couldn't find any easy way to do that as the property isn't style.

So request is for either:

  • a way to switch off the uppercase globally in variables
  • a way to switch off in theme which can then be applied to certain button classes
akhil-ga added a commit that referenced this issue Dec 6, 2017
SupriyaKalghatgi added a commit that referenced this issue Dec 7, 2017
Added feature for issue #1235
Use theme to turn off uppercase buttons on Android
@SupriyaKalghatgi
Copy link
Contributor

Fixed with NativeBase 2.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants