Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have you seen any issues with layout on iPhone X? #1234

Closed
agersoncgps opened this issue Sep 17, 2017 · 4 comments
Closed

Have you seen any issues with layout on iPhone X? #1234

agersoncgps opened this issue Sep 17, 2017 · 4 comments
Assignees
@akhil-ga
Labels
bug

Comments

@agersoncgps
Copy link

"native-base": "^2.3.2",
"react-native": "0.48.3",
Code: https://pastebin.com/WFM2HtMf

screenshot 2017-09-16 23 07 51
@KDamir
Copy link

KDamir commented Oct 17, 2017 •
edited
Loading

In Card element? Try like this: <Card style={{flexWrap: null}} />

@dtuite
Copy link

dtuite commented Oct 23, 2017

I had the same problem. @KDamir's solution fixes it.

@akhil-ga
Copy link
Contributor

akhil-ga commented Nov 9, 2017 •
edited
Loading

<Card style={{flexWrap: "nowrap"}} /> also solves the issue

@akhil-ga akhil-ga added the bug label Dec 4, 2017
akhil-ga added a commit that referenced this issue Dec 4, 2017
@akhil-ga
Fix for issue #1234
43e6c28 
Issue : card ui breaks on iphoneX
Possible fix for issue #612
akhil-ga added a commit that referenced this issue Dec 5, 2017
@akhil-ga
Added feature for issue #1234
81b1272 
Issue - Use theme to turn off uppercase buttons on Android
akhil-ga added a commit that referenced this issue Dec 6, 2017
@akhil-ga
Added feature for issue #1234. Issue - Use theme to turn off uppercas…
e09a5c0 
…e buttons on Android
SupriyaKalghatgi added a commit that referenced this issue Dec 7, 2017
@SupriyaKalghatgi
Merge pull request #1417 from GeekyAnts/fix/card/iphoneXIssue
847a624 
Fix for issue #1234
Card layout with iPhone X
@SupriyaKalghatgi
Copy link
Contributor

Fixed with NativeBase 2.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akhil-ga akhil-ga

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@agersoncgps @dtuite @KDamir @SupriyaKalghatgi @ankitsinghania94 @akhil-ga