Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCop 201 #273

Open
marjanjavid opened this issue Feb 6, 2019 · 2 comments
Open

GCop 201 #273

marjanjavid opened this issue Feb 6, 2019 · 2 comments
Assignees

Comments

@marjanjavid
Copy link
Contributor

The third sample written in this document does not fire this warning. If it is not a valid sample let me know to remove the example.
https://github.com/Geeksltd/GCop/blob/master/Rules/GCop201.md

@Karvan
Copy link
Contributor

Karvan commented Feb 12, 2019

It's a valid sample for me while it's a capital letter after the underline character.

@Foroughi
Copy link
Contributor

@marjanjavid @Karvan I can't see anything regards to the third sample in the rule logic. As I'm checking, the rule will kick in only for local declaration variables and parameters. btw I don't agree with Karvan and i think the third one is not a valid sample as its being started with an underscore char. So building on what i said, @Karvan do I need to change this rule ?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants