Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong loop logic when using LDE #23

Open
CySHell opened this issue Feb 22, 2021 · 3 comments
Open

Wrong loop logic when using LDE #23

CySHell opened this issue Feb 22, 2021 · 3 comments

Comments

@CySHell
Copy link

CySHell commented Feb 22, 2021

Inside ept.c, when counting the number of instruction bytes at the start of the hooked function, the instruction pointer is not incremented - this results in counting the length of the same instruction over and over again.

SizeOfHookedInstructions += LDE(TargetFunction, 64))

should be changed to something like:

SizeOfHookedInstructions += LDE(TargetFunction + SizeOfHookedInstructions, 64))

@Gbps
Copy link
Owner

Gbps commented Feb 22, 2021

Hey there, great find! Looks like it was overlooked but generally didn't have any issues because only one instruction's space was necessary for the example.

Could you submit a pull request so I can merge it into the main branch?

Thanks!

@CySHell
Copy link
Author

CySHell commented Feb 23, 2021

Sure, please give me authorization to create a pull request.

@Gbps
Copy link
Owner

Gbps commented May 4, 2021

Sorry, I know this was from awhile ago, but anyone should be able to open a pull request and I can review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants