Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA_POINT_WITHOUT_MEASURE rule providing #85

Open
buchslava opened this issue May 6, 2016 · 2 comments
Open

DATA_POINT_WITHOUT_MEASURE rule providing #85

buchslava opened this issue May 6, 2016 · 2 comments

Comments

@buchslava
Copy link
Collaborator

  • Rule name: Should be filled if this issue depends on particular rule especially during new rule creation. This name should be a valid JS variable name and should be used for connecting with code.

DATA_POINT_WITHOUT_MEASURE

  • Rule test folder: Should be filled if type of Request is rule. Needed for documentation auto generation.

test/fixtures/rules-cases/data-point-without-measure

  • Rule description: Should be filled if type of Request is rule. Needed for documentation auto generation.

An issue according to this rule will be fired when all or some measures in current datapoint record are undefined.

  • Examples of correct data:

ddf--datapoints--yearly_co2_emissions_tonnes--by--geo--time

geo,yearly_co2_emissions_tonnes,time
afg,14.67,1949
  • Examples of incorrect data:

ddf--datapoints--yearly_co2_emissions_tonnes--by--geo--time

geo,yearly_co2_emissions_tonnes,time
afg,,1949
  • Scenarios Should be filled if type of Request is rule.
when dataset is correct
  any issue should NOT be found for this rule
when dataset is NOT correct
  issues in accordance with wrong datapoint records quantity should be detected for this rule
  output data for any issue should be expected
  • Output data format Additional data that depends on particular issue type. Should be filled if type of Request is rule.

datapoint record
measure

@buchslava
Copy link
Collaborator Author

@jheeffer what do you think, what kind will be this issue: error or warning?

@jheeffer
Copy link
Member

jheeffer commented May 6, 2016

  1. measure is an incorrect term here, indicator is the correct one. A measure is any numeric concept, also outside of datapoints (e.g. latitude of a country). An indicator is a concept which is used as the value in a datapoint. It can also be non-numeric (so not a measure, e.g. type of government of countries over the years).
    see: https://docs.google.com/document/d/1Cd2kEH5w3SRJYaDcu-M4dU5SY8No84T3g-QlNSW6pIE/edit#heading=h.h9x68on4mvz0
  2. Definitely not an error. Maybe a warning. A missing indicator can be seen as null to explicitly indicate there is not data for that datapoint, instead of leaving it out. So not sure if it's a warning even... @angieskazka your 2 cents?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants