Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV parse errors are ignored #558

Open
jheeffer opened this issue Jan 7, 2021 · 0 comments
Open

CSV parse errors are ignored #558

jheeffer opened this issue Jan 7, 2021 · 0 comments

Comments

@jheeffer
Copy link
Member

jheeffer commented Jan 7, 2021

https://github.com/Gapminder/ddf-validation/blob/master/src/utils/file.ts#L193

https://www.papaparse.com/docs#results

parse result .error property is never checked.

Currently gapminder world DAG in airflow sometimes errors on this line because csvLine is undefined.

https://github.com/Gapminder/ddf-validation/blob/master/src/utils/file.ts#L197
@jheeffer jheeffer changed the title Read errors are ignored in read result CSV parse errors are ignored Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jheeffer