Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fctrserver): parse updated version string correctly #4688

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

Amlinde
Copy link
Contributor

@Amlinde Amlinde commented Oct 22, 2024

Description

Changes the command used to extract the server version to only take the first match so that it ignores the architecture string.

Fixes #4687

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64
Copy link
Member

I think this one is worth a hotfix release. I will get it sorted tomorrow

@Amlinde Amlinde deleted the branch GameServerManagers:develop October 24, 2024 05:02
@Amlinde Amlinde closed this Oct 24, 2024
@Amlinde Amlinde deleted the develop branch October 24, 2024 05:02
@Amlinde Amlinde restored the develop branch October 24, 2024 05:03
@Amlinde Amlinde mentioned this pull request Oct 24, 2024
@Amlinde Amlinde reopened this Oct 24, 2024
@dgibbs64 dgibbs64 changed the base branch from develop to master October 26, 2024 20:44
@dgibbs64 dgibbs64 changed the base branch from master to develop October 26, 2024 20:44
@dgibbs64
Copy link
Member

This is going to have to be rebased off master branch

@dgibbs64 dgibbs64 added this to the v24.4.0 milestone Oct 26, 2024
@dgibbs64 dgibbs64 merged commit 53a7c70 into GameServerManagers:develop Oct 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants