Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reds subscription more resilient #119

Closed
bodymindarts opened this issue Sep 19, 2022 · 3 comments
Closed

Make reds subscription more resilient #119

bodymindarts opened this issue Sep 19, 2022 · 3 comments
Assignees

Comments

@bodymindarts
Copy link
Member

bodymindarts commented Sep 19, 2022

Any time we are subscribing to redis messages - we need an outer loop that reconnects the subscriber if something fails.
Ideally handled in our Subscriber client and not in calling code.
-> implies returning an mpsc or something like that.

First investgate expected behaviour of client library.

@bodymindarts
Copy link
Member Author

First investgate expected behaviour of client library.

after looking closer it should already be re-connecting. Perhaps the custom-recconect-errors feature is missing - but not sure what is going on.

@enigbe
Copy link
Contributor

enigbe commented Sep 22, 2022

The client library reconnects fine. I tried to recreate an environment similar to the one we have in staging locally. It is not quite exact but enough to test how the library behaves when there is a network partition. The challenge here may be linked to the sentinel going down during the upgrade.

@bodymindarts
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants