New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong version comparison in CLI for checking for newer versions #394

Open

dzikowski opened this issue Oct 8, 2024 · 0 comments

Labels

good first issue

Collaborator

dzikowski commented Oct 8, 2024

This is the code from CLI:

  const cliLatestVersion = execSync("npm show @gala-chain/cli version");
  const cliCurrentVersion = execSync("galachain --version").split(" ")[0].split("/")[2];
  if (cliLatestVersion > cliCurrentVersion) {

It compares by a string, which is inappropriate, because for instance 1.4.10 < 1.4.9

The text was updated successfully, but these errors were encountered:

sentientforest added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment